Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a white eyepatch #6042

Closed
wants to merge 3 commits into from
Closed

Conversation

MOONPRINCESS17
Copy link

@MOONPRINCESS17 MOONPRINCESS17 commented Mar 29, 2024

About the pull request

Adds a white counterpart to the already existing eyepatch, which is black. This one appears exclusively in player loadouts and does not replace the classic eyepatch anywhere else.

Explain why it's good for the game

For those of discerning fashion taste. That, or any possible... gimmicks such fashion might enable.

Testing Photographs and Procedure

image

Changelog

🆑
add: Added a white eyepatch to player loadouts.
imageadd: Added sprites for a white eyepatch.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Mar 29, 2024
@Zonespace27 Zonespace27 marked this pull request as draft March 29, 2024 19:40
Copy link
Contributor

@sleepynecrons sleepynecrons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the whites are ridiculously bright. use colors from something like PMC gear if you're going to make white clothing
also is this not just you trying to add anime larp

@MOONPRINCESS17
Copy link
Author

The item is now a subtype of the normal black eyepatch and the sprite is not as luridly bright.

@MOONPRINCESS17 MOONPRINCESS17 marked this pull request as ready for review March 30, 2024 03:24
@sleepynecrons
Copy link
Contributor

after speaking with other maintainers i will be closing the PR. a white eyepatch isn't something we want marines wearing as it's visually inconsistent with the faction. white is something we should keep reserved to PMCs/W-Y specific groups. the item is also just a reference to https://myanimelist.net/character/65865/Rikka_Takanashi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants